Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address multiquery long timeouts causing excessive queue growth … #3284

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: address multiquery long timeouts causing excessive queue growth … #3284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/ceramic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ import { LevelKVFactory } from './store/level-kv-factory.js'
const METRICS_CALLER_NAME = 'js-ceramic'
const DEFAULT_CACHE_LIMIT = 500 // number of streams stored in the cache
const DEFAULT_QPS_LIMIT = 10 // Max number of pubsub query messages that can be published per second without rate limiting
const DEFAULT_MULTIQUERY_TIMEOUT_MS = 30 * 1000
const DEFAULT_MULTIQUERY_TIMEOUT_MS = 3 * 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not positive, but I believe when this timeout fires it will only fail the multiquery request but not clean up the work happening in the background in the execution queue. I think probably you want to pair this with also turning down the IPFS timeouts in the dispatcher.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i had made a separate PR for those since i only saw the multiquery errors in the logs. we could do #3285 instead. I thought that might require more testing if its hitting more locations.

const DEFAULT_MIN_ANCHOR_LOOP_DURATION_MS = 60 * 1000 // 1 minute
const TESTING = process.env.NODE_ENV == 'test'

Expand Down