OpenAIService - support for after and limit for listFineTuneEvents

cequence-io · Sep 29, 2023 · 37d8bac · 37d8bac
1 parent b017da2
commit 37d8bac
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/openai-client/src/main/scala/io/cequence/openaiscala/service/OpenAIServiceImpl.scala b/openai-client/src/main/scala/io/cequence/openaiscala/service/OpenAIServiceImpl.scala
@@ -325,12 +325,16 @@ private trait OpenAIServiceImpl extends OpenAICoreServiceImpl with OpenAIService
     ).map(response => handleNotFoundAndError(response).map(_.asSafe[FineTuneJob]))
 
   override def listFineTuneEvents(
-    fineTuneId: String
+    fineTuneId: String,
+    after: Option[String] = None,
+    limit: Option[Int] = None
   ): Future[Option[Seq[FineTuneEvent]]] =
     execGETWithStatus(
       EndPoint.fine_tunes,
       endPointParam = Some(s"$fineTuneId/events"),
       params = Seq(
+        Param.after -> after,
+        Param.limit -> limit,
         Param.stream -> Some(false) // TODO: is streaming still supported?
       )
     ).map { response =>

diff --git a/openai-core/src/main/scala/io/cequence/openaiscala/service/OpenAIService.scala b/openai-core/src/main/scala/io/cequence/openaiscala/service/OpenAIService.scala
@@ -123,8 +123,7 @@ trait OpenAIService extends OpenAICoreService {
    *   image response (might contain multiple data items - one per image)
    *
    * @see
-   *   <a href="https://platform.openai.com/docs/api-reference/images/create-edit">OpenAI
-   *   Doc</a>
+   *   <a https://platform.openai.com/docs/api-reference/images/createEdit">OpenAI Doc</a>
    */
   def createImageEdit(
     prompt: String,
@@ -144,7 +143,7 @@ trait OpenAIService extends OpenAICoreService {
    *   image response (might contain multiple data items - one per image)
    *
    * @see
-   *   <a href="https://platform.openai.com/docs/api-reference/images/create-variation">OpenAI
+   *   <a href="https://platform.openai.com/docs/api-reference/images/createVariation">OpenAI
    *   Doc</a>
    */
   def createImageVariation(
@@ -375,11 +374,10 @@ trait OpenAIService extends OpenAICoreService {
    *   <a href="https://platform.openai.com/docs/api-reference/fine-tuning/list-events">OpenAI
    *   Doc</a>
    */
-  // TODO: add pagination: after: Option[String], limit: Option[Int]
   def listFineTuneEvents(
-    fineTuneId: String
-//    after: Option[String] = None,
-//    limit: Option[Int] = None
+    fineTuneId: String,
+    after: Option[String] = None,
+    limit: Option[Int] = None
   ): Future[Option[Seq[FineTuneEvent]]]
 
   /**

diff --git a/openai-core/src/main/scala/io/cequence/openaiscala/service/OpenAIServiceWrapper.scala b/openai-core/src/main/scala/io/cequence/openaiscala/service/OpenAIServiceWrapper.scala
@@ -159,9 +159,11 @@ trait OpenAIServiceWrapper extends OpenAIService {
   )
 
   override def listFineTuneEvents(
-    fineTuneId: String
+    fineTuneId: String,
+    after: Option[String],
+    limit: Option[Int]
   ): Future[Option[Seq[FineTuneEvent]]] = wrap(
-    _.listFineTuneEvents(fineTuneId)
+    _.listFineTuneEvents(fineTuneId, after, limit)
   )
 
   override def deleteFineTuneModel(