Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

Update all old dependencies #2

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Update all old dependencies #2

merged 6 commits into from
Oct 20, 2023

Conversation

zblach
Copy link

@zblach zblach commented Oct 20, 2023

go get -u .; go mod tidy

some test broke, likely owing to package name changes. I'm running those down rn.

@zblach zblach marked this pull request as ready for review October 20, 2023 06:58
@zblach zblach requested a review from amlozano1 October 20, 2023 06:58
@zblach
Copy link
Author

zblach commented Oct 20, 2023

the newer versions of grpc calls include an output value called grpc-status-details-bin which is some serialized form of the error message. the fixtures have been updated to include this value where required.

amlozano1
amlozano1 approved these changes Oct 20, 2023
View reviewed changes
Copy link

@amlozano1 amlozano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zblach zblach merged commit 1cc0b66 into master Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amlozano1 amlozano1 amlozano1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zblach @amlozano1