Allow for CSI provisioned volume or storage class as source #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
changed the title
emosbaugh
force-pushed
the
csi-source-sc
branch
from
5912953 to
41dc1d5
Compare
emosbaugh
commented
Jan 13, 2023
| return fmt.Errorf("failed to update ReclaimPolicy for PV object %s: %v", pvc.Spec.VolumeName, err) | ||
| } | ||
|
|
||
| // retrieve and validate the volume name before starting the migration |
There was a problem hiding this comment.
i've reordered this to validate prior to mutating the resource
Madhu-1
reviewed
Jan 16, 2023
There was a problem hiding this comment.
@emosbaugh changes LGTM, update the readme for this support?
added documentation to the readme |
|
let's wait for #43 before merging |
Madhu-1
approved these changes
Jan 18, 2023
|
@emosbaugh can you please just rebase on top of main, we just fix the ci after that we'll good to merge the pr |
emosbaugh
force-pushed
the
csi-source-sc
branch
from
c5071b9 to
f9f6570
Compare
rebased |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand it is not the intention of the project as clearly stated in the readme, but I found with this small change it is possible to migrate from CSI to CSI volumes.
Our use case is migrating from a flex driver storage class, to a temporary csi storage class, deleting the flex storage class, and migrating to a csi storage class with the same name as the original flex storage class.