rbd: add EncryptionLoad2 implementing rbd_encryption_load2 #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlogistonjohn
added
the
API
|
I'm looking to add a 2nd test, one that actually tests the use of multiple encryption specs, but I haven't found any good examples yet. In the meantime, while it's still draft, I figured I'd get a test run out of what I have already. |
phlogistonjohn
force-pushed
the
jjm-rbd-enc-load2-1059
branch
from
42c3ed6 to
3aa05cc
Compare
|
Additional test added. |
phlogistonjohn
force-pushed
the
jjm-rbd-enc-load2-1059
branch
from
3aa05cc to
f197e5a
Compare
anoopcs9
requested changes
Jan 24, 2025
There was a problem hiding this comment.
I've made few suggestions, all along the same pattern, to some of the length comparison assert statements. Somehow I feel like comparing the length of data read with the length of prior(fixed) data to make more sense than comparing it with the length of read buffer for img.ReadAt(). WDYT?
idryomov
reviewed
Jan 24, 2025
phlogistonjohn
force-pushed
the
jjm-rbd-enc-load2-1059
branch
from
f197e5a to
bef69a2
Compare
|
There must be something else wrong with this change as other old tests are now panicking a bunch, I filed #1063 just to see if this was something pre-existing but those all passed without so much as a poke needed (earlier this week some of the dnf mirrors were being flaky). Unfortunately, I thought this would be a quick and easy thing to add, but I guess not. |
idryomov
reviewed
Jan 24, 2025
ansiwen
requested changes
Jan 31, 2025
phlogistonjohn
force-pushed
the
jjm-rbd-enc-load2-1059
branch
from
bef69a2 to
db6ae02
Compare
phlogistonjohn
force-pushed
the
jjm-rbd-enc-load2-1059
branch
from
c098ac8 to
2ca6350
Compare
anoopcs9
reviewed
Feb 4, 2025
phlogistonjohn
force-pushed
the
jjm-rbd-enc-load2-1059
branch
2 times, most recently
from
e8c883e to
bdac7dc
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
jjm-rbd-enc-load2-1059
branch
from
bdac7dc to
5383f06
Compare
anoopcs9
previously approved these changes
Feb 10, 2025
Fix a couple of comments to make them a bit more accurate. They were probably true at one point in the development of the feature but now referred to functions that don't exist. Signed-off-by: John Mulligan <[email protected]>
Restructure the existing rbd encryption load test function so that it makes use of defer and uses subtests to divide things up more clearly. I needed to make this change in preparation for adding a binding for rbd_encryption_load2 and a similar test - but I couldn't make sense of the existing test in it's more monolithic form. Signed-off-by: John Mulligan <[email protected]>
Add a new Image method EncryptionLoad2 implementing rbd_encryption_load2. This method adds the ability to have different encryption schemes across parent images. Signed-off-by: John Mulligan <[email protected]> Fixes: ceph#1059
Add EncryptionOptionsLUKS type for opening, but not formatting, existing LUKS images generically. Signed-off-by: John Mulligan <[email protected]>
Increase the test timeout from 10m (Go default) to 15m. Adding the three new tests for load 2 and the new generic LUKS type (mainly the longer entryption load2 test) push us over the 10m mark by just about 1 minute :-\ Signed-off-by: John Mulligan <[email protected]>
phlogistonjohn
force-pushed
the
jjm-rbd-enc-load2-1059
branch
from
5383f06 to
6f67ffb
Compare
mergify
bot
dismissed
anoopcs9’s stale review
Pull request has been modified.
anoopcs9
approved these changes
Feb 10, 2025
ansiwen
reviewed
Feb 10, 2025
ansiwen
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Image method EncryptionLoad2 implementing rbd_encryption_load2.
This method adds the ability to have different encryption schemes across
parent images.
Fixes: #1059
Checklist
//go:build ceph_previewmake api-updateto record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.