Fix pluginpath for cephfs

[Madhu-1]

Describe what this PR does

make pluginpath configurable for cephfs

[humblec]

@Madhu-1 no newline required here.

[humblec]

may be you can use a different arg name in func().. but even this is fine but one can miss the case of the letter and be confused.

[Madhu-1]

@humblec @ShyamsundarR @poornimag PTAL

[humblec]

@Madhu-1 can you please add the issue Link in the PR description ?

[humblec]

@ShyamsundarR @poornimag Please review. This PR is pretty old , so ping with a timeout :)

[Madhu-1]

Fixes: #458

[humblec]

As discussed in slack, I am merging this PR.

[jianglingxia]

@Madhu-1
the pr merge v1.2.0,but i use the csi driver v1.0,then i put the pr code to v1.0 version and make cephcsi,use the bin to build a image then deploy the two pod ,but create a pvc can not dynamic create pv and volume

the provisioner logs ,i check the mointors i set in configmap :
[root@node-7:/home/ubuntu]$ docker logs c44ec2b8c9fd
E0823 06:01:06.345306 1 controllerserver.go:59] validation of volume options failed: either monitors or monValueFromSecret should be set
E0823 06:01:06.346736 1 utils.go:109] GRPC error: rpc error: code = InvalidArgument desc = either monitors or monValueFromSecret should be set
E0823 06:01:06.857286 1 controllerserver.go:59] validation of volume options failed: either monitors or monValueFromSecret should be set
E0823 06:01:06.857351 1 utils.go:109] GRPC error: rpc error: code = InvalidArgument desc = either monitors or monValueFromSecret should be set
E0823 06:01:07.865603 1 controllerserver.go:59] validation of volume options failed: either monitors or monValueFromSecret should be set
E0823 06:01:07.865630 1 utils.go:109] GRPC error: rpc error: code = InvalidArgument desc = either monitors or monValueFromSecret should be set
E0823 06:01:09.879447 1 controllerserver.go:59] validation of volume options failed: either monitors or monValueFromSecret should be set
E0823 06:01:09.879544 1 utils.go:109] GRPC error: rpc error: code = InvalidArgument desc = either monitors or monValueFromSecret should be set
E0823 06:01:13.888292 1 controllerserver.go:59] validation of volume options failed: either monitors or monValueFromSecret should be set
E0823 06:01:13.888312 1 utils.go:109] GRPC error: rpc error: code = InvalidArgument desc = either monitors or monValueFromSecret should be set
E0823 06:01:21.946793 1 controllerserver.go:59] validation of volume options failed: either monitors or monValueFromSecret should be set
E0823 06:01:21.946814 1 utils.go:109] GRPC error: rpc error: code = InvalidArgument desc = either monitors or monValueFromSecret should be set
E0823 06:01:37.963374 1 controllerserver.go:59] validation of volume options failed: either monitors or monValueFromSecret should be set
E0823 06:01:37.963398 1 utils.go:109] GRPC error: rpc error: code = InvalidArgument desc = either monitors or monValueFromSecret should be set

[Madhu-1]

@jianglingxia there are a lot of changes between v1.0.0 and v1.2.0.

from the error, it looks like csi is not able to fetch mon values. btw how you are passing mon values?

[jianglingxia]

yes,the v1.0.0 and v1.2.0 has a lot of changes, the mon values i writer the configmap and create configmap

because that my kubernetes cluster version is v1.13,so then use the csi version v1.0.0,can you give my some idea?thanks

[Madhu-1]

@jianglingxia cephcsi v1.2.0 works with Kube 1.13. why you are using v1.0.0?

[Madhu-1]

@jianglingxia if you want to use v1.0.0 can you add monitors in storageclass and try?

[jianglingxia]

can i use k8s v1.13 and use csi version v1.2.0? thanks
but why before i use your images madhupr001/cephcsi:canary can right?and the storageclass do not add moniors

[Madhu-1]

yes you can use cephcsi v1.2.0 with kube 1.13

[jianglingxia]

but
#524 the issue if use multi replicas must need k8s v1.14

the pr kubernetes-csi/external-provisioner#249 merge the sidecar,the k8s code change it when support multi replicas ?

[Madhu-1]

you can use a single replica. refer templates from v1.13 folder example https://github.com/ceph/ceph-csi/tree/master/deploy/rbd/kubernetes/v1.13

[jianglingxia]

sorry i see the pr label v1.2.0, but the branch and realeas can not find v1.2.0,only v1.0.0 and v1.1.0

[Madhu-1]

yes, we have only released v1.1.0 and v1.0.0 we are yet to release v1.2.0 this month End.

if you are testing ceph-csi you can use the master branch