Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csiaddons: add rbac permission for setting ownerRef #171

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

rewantsoni
Copy link
Contributor

Describe what this PR does

csiaddons require new RBAC permission for setting onwerRef on csiaddonsnode obj, going to be owned by either a deployment or a daemonsets.

continued from: #166

Is there anything that requires special attention

Do you have any questions?
No

Is the change backward compatible?
Yes

Are there concerns around backward compatibility?
No

Provide any external context for the change, if any.
RBAC's are required for this new change csi-addons/kubernetes-csi-addons#695

For example:

  • Kubernetes links that explain why the change is required
  • Ceph-CSI spec related changes/catch-up that necessitates this patch
  • golang related practices that necessitates this change

Related issues

Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.

Fixes: #issue_number

Future concerns

List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide
    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes

    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

config/csi-rbac/rbd_ctrlplugin_role.yaml Outdated Show resolved Hide resolved
config/csi-rbac/rbd_nodeplugin_role.yaml Outdated Show resolved Hide resolved
csiaddons require new RBAC permission for setting onwerRef on
csiaddonsnode obj, going to be owned by either a deployment
or a daemonsets

Signed-off-by: Rewant Soni <[email protected]>
@Madhu-1 Madhu-1 merged commit 85fb846 into ceph:main Nov 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants