Sets the default version to giant #190
Conversation
| @@ -22,6 +22,26 @@ | |||
|
|
|||
| cluster = 'ceph' | |||
|
|
|||
| if node['ceph']['version'] >= 'giant' | |||
There was a problem hiding this comment.
are you sure that >= can work with future ceph version?
There was a problem hiding this comment.
The mds pools are not created by default for versions >= giant (before that they were automatically created, so there was no code in the cookbook to create the pools if not present).
After thinking about it, creating the pool "not_if" already exists should be safe with older versions and also future proof. Want me to clean this up?
|
I need some advice from @hufman and a squashing :p The only things that is shocking me (but I'm easily shocked :p) is line with not_if, if and big_mount_grep |
| @@ -29,6 +29,7 @@ def manage_mount(directory, subdir, use_fuse, action) | |||
| dump 0 | |||
| pass 0 | |||
| action action | |||
| not_if "mount | grep \"^ceph-fuse on #{Regexp.escape(directory)}\"" if action == :mount | |||
There was a problem hiding this comment.
Mounting fuse-based filesystem does not play well when the system reboots: the fstab entry is mounted again by the system, but the "mount" resource does not see that the volume is mounted and tried mounting again, which fails the chef-run. Interested in more pretty workarounds.
There was a problem hiding this comment.
The chef s3fs mount cookbook checks where the directory is a mountpoint, not specifically that it is an s3fs mountpoint.
There was a problem hiding this comment.
This change will replace #170
The fstab and stuff need the weird option string as the 'device' But the mount command shows 'ceph-fuse' as the device Chef sees that they are different and tries to mount again This adds a workaround to detect that it's already mounted
jperville
force-pushed
the
giant-cherry-picks
branch
from
8d3d747 to
83ae8c5
Compare
A few months ago, I created this branch to cherry-pick the different PRs (from @hufman and @klamontagne) that I have found useful to make this cookbook work with Ceph "giant" release.
After merging current master (as of version 0.8.0) into it, the difference between the branches became so tiny that I think it a merge into master could be considered.