Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

add ceph-node-proxy package to ubi9-based IBM images #2185

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

guits
Copy link
Collaborator

@guits guits commented Feb 13, 2024

This adds the ceph-node-proxy RPM package to the ubi9-based IBM Ceph downstream image.

This adds the ceph-node-proxy RPM package to the ubi9-based
IBM Ceph downstream image.

Signed-off-by: Guillaume Abrioux <[email protected]>
@guits
Copy link
Collaborator Author

guits commented Feb 13, 2024

@ktdreyer @bigjust @jmolmo

@bigjust
Copy link
Collaborator

bigjust commented Feb 13, 2024

@guits I regenerated the Dockerfile using make stage and didn't see the ceph-node-proxy package being added to the reef-ubi9-ibm Dockerfile, which is what I would have expected. Is that how this should be tested?

@bigjust
Copy link
Collaborator

bigjust commented Feb 13, 2024

@guits I regenerated the Dockerfile using make stage and didn't see the ceph-node-proxy package being added to the reef-ubi9-ibm Dockerfile, which is what I would have expected. Is that how this should be tested?

Its possible that I need to test this with https://pkgs.devel.redhat.com/cgit/rpms/ceph/commit/?h=ceph-7.1-rhel-9&id=9ff0aa8b9f9d7c254978d8593c50e22359d04eb1 which I will attempt, but please correct me if this is wrong

@guits
Copy link
Collaborator Author

guits commented Feb 13, 2024

@guits I regenerated the Dockerfile using make stage and didn't see the ceph-node-proxy package being added to the reef-ubi9-ibm Dockerfile, which is what I would have expected. Is that how this should be tested?

I used the script at ./contrib/compose-rhcs.sh to check that @bigjust

@bigjust
Copy link
Collaborator

bigjust commented Feb 13, 2024

As per instructions in slack, I should've used the compose-rhcs.sh to generate, and then it added this package

LGTM!

@guits guits merged commit bbe1cb8 into main Feb 13, 2024
8 checks passed
@guits guits deleted the node-proxy-ibm branch February 13, 2024 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants