This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Changes for CentOS 9 containers #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apparently there are separate files for arm64. yay. I'll come in again. |
|
@dmick is this ready to merge now? |
|
No, I've been distracted by other fires and haven't yet done the arm64 changes. Fires out, I can get to this next |
dmick
force-pushed
the
wip-c9
branch
2 times, most recently
from
3858713 to
3a7aa67
Compare
|
Passing tests here at least now. the sloppy bash/python test failures are about docker.io pull ratelimiting. I'm not happy about that. |
|
jenkins lint |
1 similar comment
|
jenkins lint |
|
jenkins flake8 |
added 5 commits
March 1, 2024 01:55
Note README.tmp: scikit still has to be resolved Signed-off-by: Dan Mick <[email protected]>
Signed-off-by: Dan Mick <[email protected]>
There was a non-release-version-specific version present, but being ignored. Signed-off-by: Dan Mick <[email protected]>
Signed-off-by: Dan Mick <[email protected]>
Signed-off-by: Dan Mick <[email protected]>
|
rebased. @guits, please have a look; you're the only one I know who has a chance of catching stupid errors. |
|
@dmick shouldn't we change the defaults? diff --git a/Makefile b/Makefile
index 6f65469c..d458b227 100644
--- a/Makefile
+++ b/Makefile
@@ -21,7 +21,8 @@ FLAVORS ?= \
pacific,centos,8 \
quincy,centos,8 \
reef,centos,8 \
- main,centos,8
+ squid,centos,9 \
+ main,centos,9
TAG_REGISTRY ?= ceph
|
|
I'm planning on doing that with a followup, once we get some experience with building/testing on c9. It's a larger decision. |
guits
approved these changes
Mar 7, 2024
|
are we ready to add this containerization step to our centos9 jenkins builds? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist: