This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Changes to allow staging/testing a container image #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmick
force-pushed
the
wip-prerelease
branch
3 times, most recently
from
3d094f0 to
536a775
Compare
New $PRERELEASE variable pulls pkgs from prerelease dir on download.ceph.com (requires PRERELEASE_USERNAME/PRERELEASE_PASSWORD in env) Existing $FORCE_BUILD ignores images on quay.io and builds unconditionally Add ability to pass in desired container flavors Hack ceph-release after installation, because ceph-release is built during ceph build, and doesn't know what we need Use tempfile to pass tagname back to parent New $TEST_BUILD_ONLY avoids attempting to push image to quay.io Avoid logging into quay.io if PRERELEASE Note: only x86_64 supported Signed-off-by: Dan Mick <[email protected]>
dmick
force-pushed
the
wip-prerelease
branch
from
536a775 to
3ba0877
Compare
|
https://2.jenkins.ceph.com/view/dmick/job/ceph-container-prerelease-build/1 shows the final test of the PRed code |
|
@guits ping |
|
@guits can you take a look please, or recommend someone else? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New $PRERELEASE variable pulls pkgs from prerelease dir on download.ceph.com (requires PRERELEASE_USERNAME/PRERELEASE_PASSWORD in env) Existing $FORCE_BUILD ignores images on quay.io and builds unconditionally Add ability to pass in desired container flavors
Hack ceph-release after installation, because ceph-release is built
during ceph build, and doesn't know what we need
Use tempfile to pass tagname back to parent
New $TEST_BUILD_ONLY avoids attempting to push image to quay.io Avoid logging into quay.io if PRERELEASE
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist: