Handle RGW hosts placement during adoption of older clusters with multiple subnets #7633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge yet. Still testing. |
In cephadm-adopt.yml TASK "Update the placement of radosgw hosts" passes module ceph_orch_apply embedded YAML via a block scalar. This YAML creates a Ceph spec of service_type RGW. The networks key of this spec supports either a list or a string. Without this patch, the networks key of the spec will only contain a string. With this patch a string is still set for the networks key, but if Ansible var radosgw_address_block contains commas, then var radosgw_address_block is split by those commas into a list and the networks key of the spec will be set to a list. Closes: https://issues.redhat.com/browse/RHCEPH-10418 Signed-off-by: John Fulton <[email protected]>
fultonj
force-pushed
the
adopt_rgw_diff_name
branch
2 times, most recently
from
915b33c to
9b9589c
Compare
In cephadm-adopt.yml TASK "Update the placement of radosgw hosts" does not handle when Ansible var cluster is something other than "ceph", unless this patch is used. Update module ceph_orch_apply to support optional cluster parameter using the same style as in module ceph_config. The command is only extended to inclue the new keyring and config options if cluster name is not ceph. This patch is necessary to migrate older clusters which were deployed when custom names were supported. Closes: https://issues.redhat.com/browse/RHCEPH-10442 Signed-off-by: John Fulton <[email protected]>
fultonj
force-pushed
the
adopt_rgw_diff_name
branch
from
9b9589c to
f521b64
Compare
|
This patch has passed testing and is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following commits which patch TASK "Update the placement of radosgw hosts" in the playbook cephadm-adopt.yml.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2339149