-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap up Nix Build for Node Wrapper #893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should either remove the Dockerfile(s) and/or rename them and/or move them to a different directory to avoid confusion, as I understand it this replaces the Dockerfile process completely?
@gpmayorga the idea is to try this image out in live networks first and then replace all the docker code later. The other reason why we do not remove all that here, is because this binary and docker images doesnt build the wasm, so we cannot use that for our non-live environments. Once we fix that (will create a PR soon) we can do the cleanup. |
@branan & @gpmayorga please have another look and give a thumbsup or ask more questions, so we can get this one in. |
I don't really know Nix well enough to judge this properly, so if everybody else is happy I am. No need to block on me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I like the idea of reading settings from file within the Nix code. I added a question but nothing critical, approving the merge from my end
This PR continues the work from @asymmetric (Thanks!) in this PR
One important thing to note, is that the build process skips building the WASM, this means that the binary and/or docker image needs to use an external spec to work. In later iterations we will add this support.
At the moment images are tagged with a
nix-do-not-use
suffix until we verify all is fine on production nodes.A following PR, once we have WASM builds, will cover cleaning up and remove duplication of RUST_TOOLCHAIN in github actions.