Maintain user mapping in Redis to speed up presence stats significantly #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 83.62% 83.66% +0.03%
==========================================
Files 38 38
Lines 7603 7669 +66
==========================================
+ Hits 6358 6416 +58
- Misses 923 927 +4
- Partials 322 326 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related centrifugal/centrifugo#750
For channel with 100k subscribers this changes the performance of presence stats from 15 ops/sec to 200000 ops/sec on my local machine.
Using a separate option here (
EnableUserMappinginRedisPresenceManagerConfig) since storing user info in Redis means using additional structures => increases memory usage on Redis side.