Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race in tests #254

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Fix data race in tests #254

merged 1 commit into from
Sep 9, 2022

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Sep 9, 2022

Fixes #253

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #254 (d42db5a) into master (04c92a7) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
- Coverage   83.31%   83.21%   -0.11%     
==========================================
  Files          36       36              
  Lines        8193     8197       +4     
==========================================
- Hits         6826     6821       -5     
- Misses       1033     1041       +8     
- Partials      334      335       +1     
Impacted Files Coverage Δ
metrics.go 84.86% <100.00%> (+0.14%) ⬆️
node.go 92.94% <100.00%> (ø)
internal/recovery/sync.go 76.27% <0.00%> (-3.39%) ⬇️
client.go 83.42% <0.00%> (-0.29%) ⬇️
hub.go 84.45% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FZambia FZambia merged commit a79a075 into master Sep 9, 2022
@FZambia FZambia deleted the fix_data_race_in_tests branch September 9, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional data race in initMetricsRegistry
2 participants