Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an unnecessary lock #230

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Remove an unnecessary lock #230

merged 1 commit into from
Jun 25, 2022

Conversation

j178
Copy link
Contributor

@j178 j178 commented Jun 24, 2022

nodeInfoMaxDelay is a const, I think it's not necessary to protect reading it.

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #230 (28e4a91) into master (ac688e1) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   84.68%   84.74%   +0.06%     
==========================================
  Files          30       30              
  Lines        5497     5494       -3     
==========================================
+ Hits         4655     4656       +1     
+ Misses        546      545       -1     
+ Partials      296      293       -3     
Impacted Files Coverage Δ
node.go 93.67% <100.00%> (-0.03%) ⬇️
internal/recovery/sync.go 74.41% <0.00%> (-4.66%) ⬇️
hub.go 85.76% <0.00%> (ø)
client.go 85.50% <0.00%> (+0.16%) ⬆️
internal/dissolve/queue.go 100.00% <0.00%> (+5.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac688e1...28e4a91. Read the comment docs.

@FZambia
Copy link
Member

FZambia commented Jun 25, 2022

Hello @j178 - good catch, thanks!

@FZambia FZambia merged commit 003a596 into centrifugal:master Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants