fix benchmark panics due to changed writer behaviour

centrifugal · Jan 11, 2023 · 40de54d · 40de54d
1 parent fbf0145
commit 40de54d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/client_test.go b/client_test.go
@@ -39,7 +39,7 @@ func newTestConnectedClientV2(t *testing.T, n *Node, userID string) *Client {
 	return client
 }
 
-func newTestConnectedClientWithTransport(t *testing.T, ctx context.Context, n *Node, transport Transport, userID string) *Client {
+func newTestConnectedClientWithTransport(t testing.TB, ctx context.Context, n *Node, transport Transport, userID string) *Client {
 	client := newTestClientCustomTransport(t, ctx, n, transport, userID)
 	if transport.ProtocolVersion() == ProtocolVersion1 {
 		connectClient(t, client)

diff --git a/hub_test.go b/hub_test.go
@@ -733,8 +733,7 @@ func BenchmarkHub_Contention(b *testing.B) {
 	}
 
 	for i := 0; i < numClients; i++ {
-		c, err := newClient(context.Background(), n, newTestTransport(func() {}))
-		require.NoError(b, err)
+		c := newTestConnectedClientWithTransport(b, context.Background(), n, newTestTransport(func() {}), "12")
 		_ = n.hub.add(c)
 		clients = append(clients, c)
 		for _, ch := range channels {
@@ -796,8 +795,7 @@ func BenchmarkHub_MassiveBroadcast(b *testing.B) {
 			for i := 0; i < numSubscribers; i++ {
 				t := newTestTransport(func() {})
 				t.setSink(sink)
-				c, err := newClient(context.Background(), n, t)
-				require.NoError(b, err)
+				c := newTestConnectedClientWithTransport(b, context.Background(), n, t, "12")
 				_ = n.hub.add(c)
 				for _, ch := range channels {
 					_, _ = n.hub.addSub(ch, c)