Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added invoice by user script for billing. #318

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

andriy-safe-ai
Copy link
Contributor

Tested on production.

@andriy-safe-ai andriy-safe-ai self-assigned this Sep 19, 2024
@andriy-safe-ai andriy-safe-ai linked an issue Sep 19, 2024 that may be closed by this pull request
@andriy-safe-ai andriy-safe-ai marked this pull request as ready for review September 19, 2024 19:35
Copy link
Contributor

@steven-safeai steven-safeai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit on the usage divisor.

# Parameters
log_message "Processing filesystem usage."
resource_spec_id=3
usage_divisor=1000000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hard to verify as a person. Are we sure it's the right number of zeros?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct amount. We divide by 1 billion.
@steven-basart

Copy link
Contributor

@steven-safeai steven-safeai Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why not just do this instead $((10**9)) # 1 billion where it's much easier to read it's 1 billion instead of having to count zeroes. If it ever changes or there's a typo it's harder to catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. I'll make the change.

Copy link
Contributor

@steven-safeai steven-safeai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andriy-safe-ai andriy-safe-ai force-pushed the 317-add-new-invoice-script-by-user branch from ddf2c2f to 5a54449 Compare September 20, 2024 00:06
@andriy-safe-ai andriy-safe-ai merged commit 8738144 into main Sep 20, 2024
@andriy-safe-ai andriy-safe-ai deleted the 317-add-new-invoice-script-by-user branch September 20, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new invoice script by user
2 participants