Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install LLVM, gflags, glog, tmux, and zsh. #17

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

xksteven
Copy link
Contributor

@xksteven xksteven commented Mar 5, 2023

Address issues #6, #7, and #9.

@xksteven xksteven requested a review from AndriyNovykov March 5, 2023 22:56
@@ -0,0 +1,14 @@
---
- name: Install tmux
Copy link
Collaborator

@AndriyNovykov AndriyNovykov Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is 'Install tmux' but we are installing SCL for GCC v7. We can also move this lower in the file. Closer to the other SCL installation plays.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! Yup I messed this one up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now.

@xksteven xksteven force-pushed the cais_ansible_playbooks branch from d259641 to 4f4f4ac Compare March 8, 2023 01:36
@@ -0,0 +1,3 @@
- hosts: all
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still needs fixing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@xksteven xksteven force-pushed the cais_ansible_playbooks branch from d3ad9ec to 769f3da Compare March 8, 2023 02:12
Copy link
Collaborator

@AndriyNovykov AndriyNovykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@xksteven
Copy link
Contributor Author

Please expand on your acronym at some point lol

@xksteven xksteven merged commit f1317d8 into main Mar 13, 2023
@xksteven xksteven deleted the cais_ansible_playbooks branch March 13, 2023 15:55
This was referenced Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants