update slurm.conf #134
Merged
update slurm.conf #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-safeai
requested changes
Jun 26, 2023
| @@ -35,20 +36,49 @@ SelectTypeParameters=CR_Core | |||
| AccountingStorageHost={{ bastion[0] }} | |||
| AccountingStorageType=accounting_storage/slurmdbd | |||
| TaskPlugin=task/affinity,task/cgroup | |||
| AccountingStorageTRES=gres/gpu,gres/gpu:A100 | |||
There was a problem hiding this comment.
This one is at the bottom of this file please edit it there or double check.
There was a problem hiding this comment.
@steven-basart
I just checked slurm.conf in prod and this is where it is located.
There was a problem hiding this comment.
I'm saying this file has these variables already defined below. Please see comment marked
There was a problem hiding this comment.
If you wish to move them here to be consistent with prod that's fine but we can't doubly define the variables.
There was a problem hiding this comment.
@steven-basart
Ok. I see it now.
steven-safeai
requested changes
Jun 26, 2023
| @@ -35,20 +36,49 @@ SelectTypeParameters=CR_Core | |||
| AccountingStorageHost={{ bastion[0] }} | |||
| AccountingStorageType=accounting_storage/slurmdbd | |||
| TaskPlugin=task/affinity,task/cgroup | |||
| AccountingStorageTRES=gres/gpu,gres/gpu:A100 | |||
There was a problem hiding this comment.
I'm saying this file has these variables already defined below. Please see comment marked
This was
linked to
issues
Jun 26, 2023
andriy-safe-ai
force-pushed
the
130-update-slurm-configuration
branch
from
f626f26 to
16f3008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add slurm config from prod to source.
Deployed a cpu dev cluster with the updated template.