-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Goslmailer install to allow for SLURM notifications #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
Additionally where and how is the token set.
Update the README docs are important.
Please reference the git issue somewhere in the pr so I can go back to look at it as well. |
Sorry I shouldn't have pinged you yet I was still writing the request |
One last thing before I forget. Squash or fixup your commits before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squish them merge :)
775803c
to
dc5d2d6
Compare
Run fix ldap before slurm role
Adds Goslmailer ansible playbook. This installs Mutt and all requisite config files and directories from our fork of goslmailer. README contains instructions on how to run the script and where to find the secrets. They are entered into the prompts that ansible makes.
Issue: #47
This does overwrite the mutt local config to ensure it functions correctly and by default it is blank. However, if, in the future other systems, want to use mutt we should look into integrating them properly.
Testing:
Installed multiple times to test idempotency.
Uninstalled multiple times to test idempotency.
Used this script to test the functionality of the service using my email as the sending email during installation:
Then used this script to test failing notifications:
All of this handling is done by slurm and without any edit from my config so the rest of the notifications are expected to work and appear to, but I am unaware of how to create some of the situations that they notify for.