Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(export): Add .docx export #151

Merged
merged 9 commits into from
Feb 16, 2022
Merged

feat(export): Add .docx export #151

merged 9 commits into from
Feb 16, 2022

Conversation

mehaase
Copy link
Contributor

@mehaase mehaase commented Feb 10, 2022

Cherry picked from @bsnyder70's PR #129 to merge with linted code.

closes #99
closes #26

ben and others added 2 commits February 10, 2022 11:11
@mehaase mehaase requested a review from emmanvg February 10, 2022 16:22
@mehaase mehaase self-assigned this Feb 10, 2022
@mehaase mehaase changed the title feat(export): Add .docx export WIP feat(export): Add .docx export Feb 10, 2022
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #151 (85fe92d) into master (54bc5a5) will increase coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   95.58%   96.04%   +0.45%     
==========================================
  Files           8        9       +1     
  Lines         748      834      +86     
==========================================
+ Hits          715      801      +86     
  Misses         33       33              
Impacted Files Coverage Δ
src/tram/tram/report/docx.py 100.00% <100.00%> (ø)
src/tram/tram/views.py 95.65% <100.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54bc5a5...85fe92d. Read the comment docs.

Move the Word doc logic into a new module and include a unit test to
cover it.

Also fix a bug with the way control characters are scrubbed from the
.docx text.
Fix flake8 errors and add a test for the docx branch of the view.
@mehaase mehaase changed the title WIP feat(export): Add .docx export feat(export): Add .docx export Feb 10, 2022
@mehaase
Copy link
Contributor Author

mehaase commented Feb 10, 2022

@emmanvg This is ready for review now.

This was referenced Feb 11, 2022
src/tram/tram/views.py Outdated Show resolved Hide resolved
Change print() to logging so that it will work cleanly when merged into
master.
@mehaase mehaase requested a review from emmanvg February 15, 2022 21:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@emmanvg emmanvg added this to the v1.1.3 milestone Feb 16, 2022
@emmanvg emmanvg merged commit a78358e into master Feb 16, 2022
@emmanvg emmanvg deleted the export-docx branch February 16, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Report as Word Doc Export Format: Word Document
2 participants