Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker ML pipeline #144

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

emmanvg
Copy link
Contributor

@emmanvg emmanvg commented Feb 9, 2022

What Changed?

  • The pipeline process when specified without the --run-forever flag will die out immediately if there are no jobs to process or when the jobs are finished processing. This causes any jobs submitted using Docker to stay in Queued state forever and are only processed when restarted.

New docker images will be needed for the update to address users that make use of the published images.

closes #131
closes #114

@emmanvg emmanvg added this to the v1.1.2 milestone Feb 9, 2022
@emmanvg emmanvg requested a review from mehaase February 9, 2022 12:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #144 (6de52f5) into master (8e60053) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files          20       20           
  Lines         835      835           
=======================================
  Hits          790      790           
  Misses         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e60053...6de52f5. Read the comment docs.

Copy link
Contributor

@m3mike m3mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I'll create a release tag (which triggers container build/publish)

@m3mike m3mike merged commit 39aa87c into master Feb 9, 2022
@emmanvg emmanvg deleted the bug/ctid-12/stuck-reports-on-docker branch February 9, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queued state problem Upload Report completion
2 participants