render Attack Tree nodes bottom to top, remove labels from edges, fix…

… typo in config
center-for-threat-informed-defense · Jun 3, 2024 · a78aa7d · a78aa7d
1 parent f34e4cb
commit a78aa7d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/attack_flow/graphviz.py b/src/attack_flow/graphviz.py
@@ -77,7 +77,7 @@ def convert_attack_tree(bundle):
     :rtype: str
     """
 
-    gv = graphviz.Digraph()
+    gv = graphviz.Digraph(graph_attr={'rankdir':'BT'})
     gv.body = _get_body_label(bundle)
     ignored_ids = get_viz_ignored_ids(bundle)
 
@@ -124,9 +124,9 @@ def convert_attack_tree(bundle):
                     shape="plaintext",
                 )
             for ref in o.get("asset_refs", []):
-                gv.edge(o.id, ref, "asset")
+                gv.edge(o.id, ref)
             for ref in o.get("effect_refs", []):
-                gv.edge(o.id, ref, "effect")
+                gv.edge(o.id, ref)
         elif o.type == "attack-asset":
             gv.node(o.id, _get_asset_label(o), shape="plaintext")
             if object_ref := o.get("object_ref"):

diff --git a/src/attack_flow_builder/src/assets/configuration/builder.config.ts b/src/attack_flow_builder/src/assets/configuration/builder.config.ts
@@ -93,7 +93,7 @@ const config: AppConfiguration = {
                                 ["campaign", "Campaign"],
                                 ["threat-actor", "Threat Actor"],
                                 ["malware", "Malware"],
-                                ["attack-tree", "ATT&CK Tree"],
+                                ["attack-tree", "Attack Tree"],
                                 ["other", "Other"]
                             ]
                         },