This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Create a new zone when click is detected #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crdgonzalezca
requested review from
draffensperger,
johnbryan and
mayurkale22
as code owners
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 26 26
Lines 622 622
Branches 76 76
=======================================
Hits 600 600
Misses 22 22Continue to review full report at Codecov.
|
draffensperger
suggested changes
May 31, 2019
packages/opencensus-web-instrumentation-zone/src/interaction-tracker.ts
Outdated
Show resolved
Hide resolved
packages/opencensus-web-instrumentation-zone/src/interaction-tracker.ts
Outdated
Show resolved
Hide resolved
packages/opencensus-web-instrumentation-zone/src/interaction-tracker.ts
Outdated
Show resolved
Hide resolved
packages/opencensus-web-instrumentation-zone/src/interaction-tracker.ts
Outdated
Show resolved
Hide resolved
packages/opencensus-web-instrumentation-zone/src/interaction-tracker.ts
Outdated
Show resolved
Hide resolved
packages/opencensus-web-instrumentation-zone/src/interaction-tracker.ts
Outdated
Show resolved
Hide resolved
packages/opencensus-web-instrumentation-zone/src/interaction-tracker.ts
Outdated
Show resolved
Hide resolved
crdgonzalezca
force-pushed
the
interaction_tracker
branch
from
f5681ba to
2d4ab0f
Compare
crdgonzalezca
force-pushed
the
interaction_tracker
branch
from
2d4ab0f to
5213864
Compare
draffensperger
approved these changes
Jun 3, 2019
RenaultAI
pushed a commit
to RenaultAI/opencensus-web
that referenced
this pull request
Nov 20, 2019
OCOption is redundant within the package ocinterceptor, hence fix that with a rename to Option. Fixes census-instrumentation#87
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new zone when a click is detected and runs the coming tasks on that new zone.
Also, modify the user_interaction example to do the requests using XMLHttpRequest.