Per spec, full url with query params needs to be part of the "http.url"

span attribute.
census-instrumentation · Jul 23, 2019 · 55447e2 · 55447e2
1 parent e383d22
commit 55447e2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/contrib/opencensus-ext-flask/opencensus/ext/flask/flask_middleware.py b/contrib/opencensus-ext-flask/opencensus/ext/flask/flask_middleware.py
@@ -146,7 +146,7 @@ def _before_request(self):
             tracer.add_attribute_to_current_span(
                 HTTP_METHOD, flask.request.method)
             tracer.add_attribute_to_current_span(
-                HTTP_URL, str(flask.request.base_url))
+                HTTP_URL, str(flask.request.url))
             execution_context.set_opencensus_attr(
                 'blacklist_hostnames',
                 self.blacklist_hostnames)

diff --git a/contrib/opencensus-ext-flask/tests/test_flask_middleware.py b/contrib/opencensus-ext-flask/tests/test_flask_middleware.py
@@ -263,7 +263,11 @@ def test_query_params_are_not_included_as_part_of_span_name(self):
             span = tracer.current_span()
 
             expected_attributes = {
-                'http.url': u'http://localhost/path/value',
+                # NOTE: Query params need to be include as per spec
+                # https://github.com/census-instrumentation/opencensus-specs
+                # TODO: Open feedback PR to spec and suggestion making query
+                # params optional since they can contain sensitive data
+                'http.url': u'http://localhost/path/value?foo=bar&bar=baz',
                 'http.method': 'GET',
             }