This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
adds set_kind func for oc_trace #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsloughter
reviewed
Aug 13, 2020
test/oc_span_SUITE.erl
Outdated
| @@ -53,10 +53,13 @@ modifications(_Config) -> | |||
| Span6 = oc_span:add_link(Link, Span5), | |||
| ?assertEqual(undefined, oc_span:add_link(Link, undefined)), | |||
|
|
|||
| ?assertEqual({error, no_report_buffer}, oc_span:finish_span(#span_ctx{}, Span6)), | |||
| Span7 = oc_span:set_kind(<<"SERVER">>, Span6), | |||
There was a problem hiding this comment.
span_kind() is an atom not a binary.
|
My first thought was that maybe the spec said kind could only be set when a span is started. I can't find that in the spec so I guess this is fine, only issue is the test using a binary instead of an atom. |
|
yeah we are starting the trace I'll change that to an atom, thanks for reviewing! |
castengo
force-pushed
the
set-kind
branch
2 times, most recently
from
4639e04 to
b522ef0
Compare
castengo
commented
Aug 17, 2020
| %%-------------------------------------------------------------------- | ||
| -spec span_kind_server() -> span_kind(). | ||
| span_kind_server() -> ?SPAN_KIND_SERVER. | ||
|
|
There was a problem hiding this comment.
Cool, can you add it for all the kinds and then i'll merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.