Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ToggleButtonGroup): Fix enforced and exclusive props #1572

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix(ToggleButtonGroup): Fix enforced and exclusive props #1572

merged 2 commits into from
Nov 20, 2024

Conversation

silvalaura
Copy link
Collaborator

@silvalaura silvalaura commented Nov 15, 2024 •
edited
Loading

Issue: #1565

What I did

  • Replace event.target with event.currentTarget so that whether the icon or the edge of a button gets clicked, the toggle button still gets selected as expected
  • Add unit tests

Screenshots:

N/A

Checklist

  • changeset has been added
  • Pull request description is descriptive
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

How to test

@silvalaura silvalaura self-assigned this Nov 15, 2024
@silvalaura silvalaura requested a review from a team as a code owner November 15, 2024 16:58
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: 9f98b91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-magma-dom Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silvalaura silvalaura added the blocks release High priority tickets that block next release label Nov 15, 2024
@silvalaura silvalaura linked an issue Nov 15, 2024 that may be closed by this pull request
Toggle Button Group: enforced and exlusive props do not behave as expected #1565
Closed
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://docs-preview-1572--upbeat-sinoussi-f675aa.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://storybook-preview-1572--upbeat-sinoussi-f675aa.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://docs-preview-1572--upbeat-sinoussi-f675aa.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://storybook-preview-1572--upbeat-sinoussi-f675aa.netlify.app

@silvalaura silvalaura added the ready for review Pull requests that are ready for developer review label Nov 15, 2024
@moathabuhamad-cengage moathabuhamad-cengage added needs design feedback Waiting for Design approval or feedback and removed ready for review Pull requests that are ready for developer review labels Nov 18, 2024
@orion-cengage orion-cengage self-requested a review November 20, 2024 13:40
@orion-cengage orion-cengage removed the needs design feedback Waiting for Design approval or feedback label Nov 20, 2024
@silvalaura silvalaura merged commit b8364bb into dev Nov 20, 2024
3 checks passed
@silvalaura silvalaura deleted the fix/toggleBtnGroupEnforced branch November 20, 2024 15:45
silvalaura added a commit that referenced this pull request Dec 16, 2024
@silvalaura
fix(ToggleButtonGroup): Fix enforced and exclusive props (#1572)
bd1c3e6
silvalaura added a commit that referenced this pull request Dec 17, 2024
@silvalaura
fix(ToggleButtonGroup): Fix enforced and exclusive props (#1572)
46db002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orion-cengage orion-cengage orion-cengage approved these changes

@chris-cedrone-cengage chris-cedrone-cengage chris-cedrone-cengage approved these changes

@moathabuhamad-cengage moathabuhamad-cengage moathabuhamad-cengage approved these changes

@nikitaorliak-cengage nikitaorliak-cengage Awaiting requested review from nikitaorliak-cengage

Assignees

@silvalaura silvalaura

Labels
blocks release High priority tickets that block next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toggle Button Group: enforced and exlusive props do not behave as expected
4 participants
@silvalaura @orion-cengage @chris-cedrone-cengage @moathabuhamad-cengage