Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix contribution guidelines page #1548

Merged
merged 1 commit into from
Nov 13, 2024
Merged

docs: Fix contribution guidelines page #1548

merged 1 commit into from
Nov 13, 2024

Conversation

silvalaura
Copy link
Collaborator

Issue: none

What I did

Contribution guidelines page was not loading because it doesn't have any headings

Screenshots:

Before:
image

Checklist

  • changeset has been added
  • Pull request description is descriptive
  • I have made corresponding changes to the documentation
  • [-] New and existing unit tests pass locally with my changes
  • [-] I have added tests that prove my fix is effective or that my feature works

How to test

Confirm that the Contribution Guidelines page can be reached

@silvalaura silvalaura added the ready for review Pull requests that are ready for developer review label Nov 12, 2024
@silvalaura silvalaura self-assigned this Nov 12, 2024
@silvalaura silvalaura requested a review from a team as a code owner November 12, 2024 16:39
Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: 1cfd632

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-magma-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copy link
Contributor

@silvalaura silvalaura merged commit 8027499 into dev Nov 13, 2024
2 checks passed
@silvalaura silvalaura deleted the docs/contGuidelines branch November 13, 2024 14:21
@moathabuhamad-cengage
Copy link
Collaborator

✅ page opens with no errors

Tested on :
Chrome Version 128.0.6613.137 (Official Build) (64-bit)
Firefox 132.0.2 (64-bit)
Safari 18 macOS Sequoia

https://next--upbeat-sinoussi-f675aa.netlify.app/contribution-guidelines/

@moathabuhamad-cengage moathabuhamad-cengage removed the ready for review Pull requests that are ready for developer review label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocks release High priority tickets that block next release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants