fix(drawer): Fix trapped focus in the drawer #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemtrusov-cengage
added
bug
artemtrusov-cengage
requested review from
silvalaura and
a team
as code owners
🦋 Changeset detectedLatest commit: 8dad993 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This solution also addresses #970 |
silvalaura
reviewed
Oct 1, 2024
There was a problem hiding this comment.
We just need to add .md to the filename so the changeset is detected
silvalaura
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1241
What I did
A filtering function was added to the
useFocusLockhook, which filters out invisible elements that were being included in thefocusableItems.currentarray and preventing the focus from being properly locked on the modal window.Screenshots:
Checklist
How to test