v055o #1581
v055o #1581
Conversation
There was a problem hiding this comment.
I'm sorry for meddling into your codebase, but this is a completely wrong approach in Android. It can lead to lifecycle issues, memory leaks, and difficulty in managing coroutine scopes. Adapter and ViewHolder classes should be lightweight and contain almost no logic or calculations, especially the coroutines. It should only passively receive data from Fragment/ViewModel, sometimes map it and draw it. Please, perform calculations and launch coroutines in a ViewModel or a similar layer and pass the processed data to the adapter. This keeps the adapter lean and focused on UI concerns, adhering to the Single Responsibility Principle.
My bugs that I experienced is probably because of this. ViewHolder might live 1-5 seconds and be destroyed, hence must not launch any coroutines. @hussainmohd-a @ignoramous
There was a problem hiding this comment.
@soshial: Thank you for your valuable feedback and for pointing out the potential issues with our current approach.
Our current implementation uses coroutines in the adapter due to the specific nature of our data fetching, which involves retrieving data from both the database and a network library (Go lib). This approach is indeed a temporary solution to meet our immediate needs. We acknowledge that this is not the ideal or long-term strategy and may lead to the issues you've mentioned.
We are actively working on optimizing this setup and plan to refactor it to ensure that data processing and coroutine management are handled in a more appropriate layer, such as the ViewModel.
Your insights are greatly appreciated and will help us improve our codebase.
| while (input.read(buffer).also { bytesRead = it } != -1) { | ||
| output.write(buffer, 0, bytesRead) | ||
| } | ||
| output.close() |
There was a problem hiding this comment.
close in finally?
Also, is there a need for copy to close streams when the callers are using copy within kt's use{} block?
There was a problem hiding this comment.
This has been removed: 4083e75
wg changes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/full/java/com/celzero/bravedns/scheduler/EnhancedBugReport.kt
Dismissed
Show dismissed
Hide dismissed
No description provided.