Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify proxies in contract release verification #5828

Merged
merged 13 commits into from
Nov 19, 2020
Merged

Verify proxies in contract release verification #5828

merged 13 commits into from
Nov 19, 2020

Conversation

yorhodes
Copy link
Contributor

@yorhodes yorhodes commented Nov 12, 2020 •
edited
Loading

Description

  • Adds storage verification to verify-release when proxy contracts are proposed to be changed

Other changes

Tested

Screen Shot 2020-11-11 at 5 44 02 PM

Related issues

Backwards compatibility

Yes.

@yorhodes yorhodes force-pushed the yorhodes/verify-proxies branch from f971280 to 43eb4c8 Compare November 12, 2020 01:17
@yorhodes yorhodes requested review from m-chrzan and nambrot November 12, 2020 01:45
@yorhodes yorhodes changed the title Yorhodes/verify proxies Verify proxies in contract release verification Nov 12, 2020
nambrot
nambrot approved these changes Nov 12, 2020
View reviewed changes
packages/protocol/lib/proxy-utils.ts
'latest'
)

const trie = new SecureTrie()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little less exciting than I was hoping for :P

@yorhodes yorhodes added the automerge Have PR merge automatically when checks pass label Nov 13, 2020
@yorhodes yorhodes force-pushed the yorhodes/verify-proxies branch 2 times, most recently from e981928 to 7923474 Compare November 13, 2020 23:03
@nambrot nambrot removed the automerge Have PR merge automatically when checks pass label Nov 19, 2020
@yorhodes yorhodes force-pushed the yorhodes/verify-proxies branch from 6ecc4d9 to 24a5ef8 Compare November 19, 2020 22:09
@yorhodes yorhodes merged commit f4d05ef into master Nov 19, 2020
@aaronmgdr aaronmgdr deleted the yorhodes/verify-proxies branch August 16, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-chrzan m-chrzan m-chrzan left review comments

@nambrot nambrot nambrot approved these changes

@asaj asaj Awaiting requested review from asaj

@cmcewen cmcewen Awaiting requested review from cmcewen

@nategraf nategraf Awaiting requested review from nategraf

@timmoreton timmoreton Awaiting requested review from timmoreton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

verify-release should verify the storage root of a new proxy
3 participants
@yorhodes @nambrot @m-chrzan