Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try CircleCI memory+ class to fix build step (6GB instead of 4GB of memory) #1770

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

jeanregisser
Copy link
Contributor

@jeanregisser jeanregisser commented Nov 19, 2019

Description

Though #1549 built fine, merging it caused the initial install step to run out of memory:

https://app.circleci.com/jobs/github/celo-org/celo-monorepo/66762
Screenshot 2019-11-19 at 15 11 03

This PR makes CircleCI run the failing step with a VM with more memory (6GB instead of the default 4GB).

Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any theories why a smaller yarn.lock is now requiring more resources?

@jeanregisser
Copy link
Contributor Author

jeanregisser commented Nov 19, 2019

Given more packages are now deduplicated, there are more packages in the root node_modules.
In this specific case the mobile build step consumed more memory apparently.
So my guess is TypeScript parsing more typings from the root node_modules/@types folder (by default it includes all typings there).

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f5a8fc9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1770   +/-   ##
=========================================
  Coverage          ?   74.16%           
=========================================
  Files             ?      278           
  Lines             ?     7656           
  Branches          ?      674           
=========================================
  Hits              ?     5678           
  Misses            ?     1860           
  Partials          ?      118
Flag Coverage Δ
#mobile 74.16% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a8fc9...a096139. Read the comment docs.

@jeanregisser jeanregisser added the automerge Have PR merge automatically when checks pass label Nov 19, 2019
@jeanregisser jeanregisser merged commit a1d6a59 into master Nov 19, 2019
@jeanregisser jeanregisser deleted the jeanregisser/fix-ci-install-memory-issue branch November 19, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants