[FLAKEY SETUP] protocol-test -> protocol -> Contract: Attestations-> "before each" hook for "should delete the unselected request" #4570
Labels
Comments
alecps
added
protocol
mergify bot
pushed a commit
that referenced
this issue
Aug 11, 2020
### Description - This change should fix the flakey `error: Invalid JSON RPC response: ""` error that we often see in the protocol test beforeEach hooks (particularly those for the Attestations contract). - Implements a custom beforeEachWithRetries hook for the protocol tests package that will optionally retry beforeEach hooks and add sleep in between retries. This is necessary to avoid flakiness that seems to be caused by port exhaustion in CI and a mishandling of the error by web3. (See web3/web3.js#3425 and web3/web3.js#926). - I've only added `beforeEachWithRetries` to the Attestations tests because this error appears there the most. We can add it elsewhere in the future as needed. ### Other changes None ### Tested To see that this works, search logs for "retry" in https://circleci.com/gh/celo-org/celo-monorepo/248635 ### Related issues - Fixes #4570 ### Backwards compatibility Not applicable
ewilz
pushed a commit
to ewilz/celo-monorepo
that referenced
this issue
Sep 29, 2020
### Description - This change should fix the flakey `error: Invalid JSON RPC response: ""` error that we often see in the protocol test beforeEach hooks (particularly those for the Attestations contract). - Implements a custom beforeEachWithRetries hook for the protocol tests package that will optionally retry beforeEach hooks and add sleep in between retries. This is necessary to avoid flakiness that seems to be caused by port exhaustion in CI and a mishandling of the error by web3. (See web3/web3.js#3425 and web3/web3.js#926). - I've only added `beforeEachWithRetries` to the Attestations tests because this error appears there the most. We can add it elsewhere in the future as needed. ### Other changes None ### Tested To see that this works, search logs for "retry" in https://circleci.com/gh/celo-org/celo-monorepo/248635 ### Related issues - Fixes celo-org#4570 ### Backwards compatibility Not applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
"before each" hook for "should delete the unselected request":
Error: Invalid JSON RPC response: ""
at Object.InvalidResponse (/home/circleci/app/node_modules/web3-core-helpers/src/errors.js:42:16)
at XMLHttpRequest.request.onreadystatechange (/home/circleci/app/node_modules/web3-providers-http/src/index.js:98:32)
at XMLHttpRequestEventTarget.dispatchEvent (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request-event-target.ts:44:13)
at XMLHttpRequest._setReadyState (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request.ts:219:8)
at XMLHttpRequest._onHttpRequestError (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request.ts:379:8)
at ClientRequest. (/home/circleci/app/node_modules/xhr2-cookies/xml-http-request.ts:266:37)
at Socket.socketOnEnd (_http_client.js:426:9)
at endReadableNT (_stream_readable.js:1145:12)
at process._tickCallback (internal/process/next_tick.js:63:19)
The text was updated successfully, but these errors were encountered: