Deduplicate yarn packages (#1549)

celo-org · Nov 19, 2019 · fc08761 · fc08761
1 parent 3b15c1d
commit fc08761
Show file tree

Hide file tree

Showing 10 changed files with 493 additions and 4,208 deletions.
diff --git a/packages/celotool/src/lib/generate_utils.ts b/packages/celotool/src/lib/generate_utils.ts
@@ -4,7 +4,7 @@ import { ec as EC } from 'elliptic'
 import fs from 'fs'
 import { range, repeat } from 'lodash'
 import path from 'path'
-import rlp from 'rlp'
+import * as rlp from 'rlp'
 import Web3 from 'web3'
 import { envVar, fetchEnv, fetchEnvOrFallback, monorepoRoot } from './env-utils'
 import {
@@ -166,7 +166,6 @@ const generateIstanbulExtraData = (validators: Validator[]) => {
     '0x' +
     repeat('0', istanbulVanity * 2) +
     rlp
-      // @ts-ignore
       .encode([
         // Added validators
         validators.map((validator) => Buffer.from(validator.address, 'hex')),

diff --git a/packages/celotool/src/lib/utils.ts b/packages/celotool/src/lib/utils.ts
@@ -42,8 +42,12 @@ export function execCmd(
     )
 
     if (pipeOutput) {
-      execProcess.stdout.pipe(process.stdout)
-      execProcess.stderr.pipe(process.stderr)
+      if (execProcess.stdout) {
+        execProcess.stdout.pipe(process.stdout)
+      }
+      if (execProcess.stderr) {
+        execProcess.stderr.pipe(process.stderr)
+      }
     }
   })
 }

diff --git a/packages/contractkit/src/test-utils/PromiEventStub.ts b/packages/contractkit/src/test-utils/PromiEventStub.ts
@@ -12,6 +12,9 @@ interface PromiEventStub<T> extends PromiEvent<T> {
 export function promiEventSpy<T>(): PromiEventStub<T> {
   const ee = new EventEmitter()
   const pe: PromiEventStub<T> = {
+    finally: () => {
+      throw new Error('not implemented')
+    },
     catch: () => {
       throw new Error('not implemented')
     },

diff --git a/packages/mobile/src/qrcode/QRScanner.tsx b/packages/mobile/src/qrcode/QRScanner.tsx
@@ -51,7 +51,7 @@ class QRScanner extends React.Component<Props, State> {
         Logger.debug('QRScanner', 'Bar code detected')
         this.props.handleBarcodeDetected(rawData)
       })
-      this.timeout = setTimeout(() => {
+      this.timeout = window.setTimeout(() => {
         this.setState({ isScanningEnabled: true })
       }, 1000)
     }

diff --git a/packages/mobile/src/verify/VerificationInputScreen.tsx b/packages/mobile/src/verify/VerificationInputScreen.tsx
@@ -91,7 +91,7 @@ class VerificationInputScreen extends React.Component<Props, State> {
   }
 
   componentDidMount() {
-    this.interval = setInterval(() => {
+    this.interval = window.setInterval(() => {
       const timer = this.state.timer
       if (timer === 1) {
         clearInterval(this.interval)

diff --git a/packages/mobile/src/verify/VerificationInterstitialScreen.tsx b/packages/mobile/src/verify/VerificationInterstitialScreen.tsx
@@ -24,7 +24,7 @@ class VerificationInterstitialScreen extends React.Component<WithNamespaces> {
   timeout: number | undefined
 
   componentDidMount() {
-    this.timeout = setTimeout(() => {
+    this.timeout = window.setTimeout(() => {
       navigate(Screens.VerificationInputScreen)
     }, SCREEN_DURATION)
   }

diff --git a/packages/mobile/src/web3/saga.ts b/packages/mobile/src/web3/saga.ts
@@ -64,7 +64,7 @@ export function* checkWeb3SyncProgress() {
       Logger.debug(TAG, 'checkWeb3SyncProgress', 'Checking sync progress')
 
       // isSyncing returns a syncProgress object when it's still syncing, false otherwise
-      const syncProgress = yield web3.eth.isSyncing()
+      const syncProgress = yield call(web3.eth.isSyncing)
 
       if (typeof syncProgress === 'boolean' && !syncProgress) {
         Logger.debug(TAG, 'checkWeb3SyncProgress', 'Sync maybe complete, checking')

diff --git a/packages/react-components/analytics/wrapper.tsx b/packages/react-components/analytics/wrapper.tsx
@@ -58,8 +58,8 @@ export default function Initializer(CeloAnalytics: CeloAnalyticsType, Logger: Re
       }
     }
 
-    function forwardRef(props: {}, ref?: React.Ref<React.ReactElement<any>>) {
-      return <ComponentWithAnalytics {...props as P} forwardedRef={ref} />
+    function forwardRef(props: P, ref: any) {
+      return <ComponentWithAnalytics {...props} forwardedRef={ref} />
     }
 
     forwardRef.displayName = `WithAnalytics(${displayName})`

diff --git a/packages/transaction-metrics-exporter/src/index.ts b/packages/transaction-metrics-exporter/src/index.ts
@@ -2,8 +2,8 @@ import express from 'express'
 import * as PromClient from 'prom-client'
 import { metricExporterWithRestart } from './blockchain'
 
-process.on('unhandledRejection', (error) => {
-  console.log('unhandledRejection', error.message)
+process.on('unhandledRejection', (reason) => {
+  console.log('unhandledRejection', reason)
   process.exit(1)
 })