Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

feat(readme): add FAQ section #64

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(readme): add FAQ section #64

wants to merge 7 commits into from

Conversation

therealharpaljadeja
Copy link
Contributor

@0xarthurxyz please suggest anymore questions you would like me to add here

@therealharpaljadeja therealharpaljadeja linked an issue Feb 17, 2023 that may be closed by this pull request
@therealharpaljadeja therealharpaljadeja added the documentation Improvements or additions to documentation label Feb 22, 2023
@therealharpaljadeja therealharpaljadeja requested review from eelanagaraj and removed request for arthurgousset March 2, 2023 19:31
README.md Outdated
## FAQ

<details>
<summary>What is an Identifier?</summary>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this up into the specific terms used in the SDK: plaintextIdentifier, obfuscatedIdentifier and making the differences clear? (Maybe even some text examples of what each of these looks like)

This glossary may be helpful for reusing some definitions here + elsewhere!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create a Mermaid diagram instead to explain the terminologies.

README.md Outdated
<details>
<summary>Does Issuer need to pay for gas?</summary>

Yes, Issuer pays for gas every time it wants to attest a new user.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't strictly true--the issuer only pays for gas if they publish the attestations on-chain on behalf of the user. Issuers can return the signed attestation to the user, who can then choose to publish this to FederatedAttestations.sol or not.

<details>
<summary>Does Issuer need to have ODIS quota?</summary>

Yes, Issuer needs to have ODIS Quota to register and lookup users.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is recommended but not strictly required; recommended since it promotes interoperable identifiers. This isn't necessary when issuers do not care about identifiers that use ODIS peppers; in these cases issuers can also use proprietary prefixes/salts, which means giving up interoperability but provides additional security

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that users can do the ODIS part themselves and then simply provide the obfuscatedIdentifier to be registered under the respective issuer?

Same for lookup.

Technically that would mean the authSigner will be the user requesting registration and the dApp would basically look up its balance and request to buy quota in-app, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of proprietary prefixes, wouldn't it be mandatory for issuers to have ODIS quota?

I am assuming the issuer wouldn't want its users to know the prefix and thus will have to perform the process of getting the obfuscatedIdentifier itself.

README.md Outdated
</details>

<details>
<summary>What are some security & trust assumptions differences between the Asv1 vs. Social Connect?</summary>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: capitalize ASv1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FAQ
2 participants