Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 给所有的package.json统一添加了依赖tslib #215

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

Groupguanfang
Copy link
Contributor

No description provided.

Copy link
Member

@muxiangqiu muxiangqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我理解 examples 里面的项目不需要 tslib 吧,应为 这些项目的 tsconfig.json 是独立的

@@ -52,5 +52,7 @@
"ai-packages/*",
"examples/*"
],
"dependencies": {}
"dependencies": {
"tslib": "^2.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要吧

@@ -39,7 +39,8 @@
"temp": "^0.9.4",
"ts-node": "^10.9.1",
"tslint": "^6.1.3",
"typescript": "~5.4.5"
"typescript": "~5.4.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个模块没有ts 代码吧,应该不需要

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli 模块下面的 templates 里面有两个项目需要看看 cell-component 和 monorepo 两个模版需要看看

@Groupguanfang
Copy link
Contributor Author

我理解 examples 里面的项目不需要 tslib 吧,应为 这些项目的 tsconfig.json 是独立的

我是使用一个小脚本批量添加的,examples目录确实不用,四点之后有时间我重新commit一下

@muxiangqiu muxiangqiu merged commit c587d12 into cellbang:main Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants