refactor: 将@celljs/cli-common中使用了ts-node的地方，改为使用importx-tsup包进行动态require #211
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muxiangqiu
reviewed
Oct 20, 2024
| return obj.default; | ||
| } else if (typeof obj === 'object' && typeof obj.default === 'function') { | ||
| return obj; | ||
| } else {return obj; } |
There was a problem hiding this comment.
} else {return obj; } 不建议放成一行
There was a problem hiding this comment.
{return obj; } 缺少空格 { return obj; }
|
由于使用了importx，目前尝试完善一个vitesse模版。目前大概完善了50%左右：
|
muxiangqiu
reviewed
Oct 20, 2024
| return obj.default; | ||
| } else if (typeof obj === 'object' && typeof obj.default === 'function') { | ||
| return obj; | ||
| } else return obj; |
There was a problem hiding this comment.
} else return obj; 改成如下：
} else {
return obj;
}
examples/vitesse-app/package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@celljs/cli": "3.0.0", | ||
| "@celljs/cli-service": "3.0.0", |
There was a problem hiding this comment.
"@celljs/cli-service": "3.0.0",
这个依赖可以不用添加
|
没毛病 |
muxiangqiu
changed the title
ts-node的地方，改为使用importx-tsup包进行动态requirets-node的地方，改为使用importx-tsup包进行动态require #211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本来想直接使用
importx的，发现importx没有提供CommonJS产物，于是我便自己fork了一份importx，移除掉unbuild改为使用tsup编译出CommonJS产物，发包到了npm：importx-tsup。@muxiangqiu 您也可以去改一份发npm，要不然importx无法在celljs中正常使用。现在这个版本是没问题的，可以直接执行
yarn workspace @celljs/example-backend-app start进行测试，控制台能完美打印出webpack-hook字样。