Skip to content

Commit

Permalink
Initialize channel Blocks directly on the heap
Browse files Browse the repository at this point in the history
The channel's `Block::new` was causing a stack overflow because it held
32 item slots, instantiated on the stack before moving to `Box::new`.
The 32x multiplier made modestly-large item sizes untenable.

That block is now initialized directly on the heap.

Fixes rust-lang#102246
  • Loading branch information
cuviper committed Nov 7, 2024
1 parent a2eaef7 commit 6d63012
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions std/src/sync/mpmc/list.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,14 @@ struct Block<T> {

impl<T> Block<T> {
/// Creates an empty block.
fn new() -> Block<T> {
fn new() -> Box<Block<T>> {
// SAFETY: This is safe because:
// [1] `Block::next` (AtomicPtr) may be safely zero initialized.
// [2] `Block::slots` (Array) may be safely zero initialized because of [3, 4].
// [3] `Slot::msg` (UnsafeCell) may be safely zero initialized because it
// holds a MaybeUninit.
// [4] `Slot::state` (AtomicUsize) may be safely zero initialized.
unsafe { MaybeUninit::zeroed().assume_init() }
unsafe { Box::new_zeroed().assume_init() }
}

/// Waits until the next pointer is set.
Expand Down Expand Up @@ -199,13 +199,13 @@ impl<T> Channel<T> {
// If we're going to have to install the next block, allocate it in advance in order to
// make the wait for other threads as short as possible.
if offset + 1 == BLOCK_CAP && next_block.is_none() {
next_block = Some(Box::new(Block::<T>::new()));
next_block = Some(Block::<T>::new());
}

// If this is the first message to be sent into the channel, we need to allocate the
// first block and install it.
if block.is_null() {
let new = Box::into_raw(Box::new(Block::<T>::new()));
let new = Box::into_raw(Block::<T>::new());

if self
.tail
Expand Down

0 comments on commit 6d63012

Please sign in to comment.