This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Error handling before logic in HasDescend #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
- Coverage 86.05% 85.68% -0.37%
==========================================
Files 6 6
Lines 466 468 +2
==========================================
Hits 401 401
- Misses 37 39 +2
Partials 28 28
Continue to review full report at Codecov.
|
liamsi
approved these changes
Jul 25, 2021
odeke-em
approved these changes
Jul 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48.
Do error handling separately and before the function's logic. This avoids
(true, non-nil)return value.