Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Fix non-idiomatic error check #18

Merged
merged 3 commits into from
Mar 9, 2021
Merged

Fix non-idiomatic error check #18

merged 3 commits into from
Mar 9, 2021

Conversation

adlerjohn
Copy link
Member

Use idiomatic err != nil instead of non-idiomatic err == nil.

liamsi
liamsi reviewed Feb 21, 2021
View reviewed changes
smt.go Show resolved Hide resolved
tzdybal
tzdybal reviewed Feb 27, 2021
View reviewed changes
smt.go Outdated Show resolved Hide resolved
@adlerjohn @tzdybal
Update smt.go
be618ae 
Fix return to `nil` to error

Co-authored-by: Tomasz Zdybał <[email protected]>
tzdybal
tzdybal reviewed Feb 27, 2021
View reviewed changes
smt.go Outdated Show resolved Hide resolved
@adlerjohn @tzdybal
Update smt.go
f79df6a 
Return `nil` error on success.

Co-authored-by: Tomasz Zdybał <[email protected]>
@adlerjohn adlerjohn merged commit edfd329 into celestiaorg:master Mar 9, 2021
@adlerjohn adlerjohn deleted the adlerjohn-update_idiomatic_err branch March 9, 2021 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liamsi liamsi liamsi left review comments

@tzdybal tzdybal tzdybal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adlerjohn @tzdybal @liamsi