feat: add KeyringKeyname #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcstein
commented
Aug 28, 2024
| @@ -14,7 +14,13 @@ | |||
| ## Example usage | |||
|
|
|||
| ``` | |||
| ./celestia-server --enable-rpc --rpc-addr $RPC_ADDR --rpc-port $RPC_PORT --celestia.auth-token $AUTH_TOKEN --celestia.gas-price $GAS_PRICE --celestia.gas-multiplier $GAS_MULTIPLIER --celestia.namespace-id $NAMESPACEID --celestia.rpc $CELESTIA_NODE_ENDPOINT | |||
| ./celestia-server --enable-rpc --rpc-addr $RPC_ADDR \ | |||
There was a problem hiding this comment.
This is just to improve UX of the readme and avoid people sidescrolling, so they can see things at once
jcstein
commented
Aug 28, 2024
| @@ -38,6 +38,7 @@ type DAConfig struct { | |||
| NamespaceId string `koanf:"namespace-id" ` | |||
| AuthToken string `koanf:"auth-token" reload:"hot"` | |||
| ReadAuthToken string `koanf:"read-auth-token" reload:"hot"` | |||
| KeyringKeyname string `koanf:"keyring-keyname" reload:"hot"` | |||
There was a problem hiding this comment.
I added these in this spot of the struct so that DA-related auth stuff is near each other. Totally cool to move elsewhere if it makes more sense
jcstein
commented
Aug 28, 2024
| @@ -704,3 +717,8 @@ func (c *CelestiaDA) returnErrorHelper(err error) (*ReadResult, error) { | |||
|
|
|||
| return nil, err | |||
| } | |||
|
|
|||
| // Validate that the KeyringKeyname is a alphanumeric string of length > 0 | |||
| func isValidKeyringKeyname(name string) bool { | |||
There was a problem hiding this comment.
I'm not sure if we need this tbh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #3