Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mainnet.md #1835

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Update mainnet.md #1835

merged 1 commit into from
Dec 19, 2024

Conversation

nodersteam
Copy link
Contributor

@nodersteam nodersteam commented Dec 19, 2024

Add NODERS endpoints

Overview

Summary by CodeRabbit

  • New Features
    • Added new community RPC, API, and gRPC endpoints for enhanced connectivity on the Celestia Mainnet Beta.
      • RPC: celestia-rpc.noders.services
      • API: celestia-api.noders.services
      • gRPC: celestia-grpc.noders.services:11090

Add NODERS endpoints
Copy link
Contributor

coderabbitai bot commented Dec 19, 2024

Walkthrough

The pull request updates the how-to-guides/mainnet.md documentation to include new community endpoints for the Celestia Mainnet Beta. The additions encompass three types of endpoints provided by the Noders.services community: a new RPC endpoint, an API endpoint, and a gRPC endpoint. These additions expand the connectivity options for users participating in the Celestia Mainnet, providing alternative connection methods for different node types.

Changes

File Change Summary
how-to-guides/mainnet.md Added new community endpoints:
- RPC: celestia-rpc.noders.services
- API: celestia-api.noders.services
- gRPC: celestia-grpc.noders.services:11090

Possibly related PRs

Suggested reviewers

  • jcstein
  • rootulp

Poem

🌟 Endpoints Dancing in the Mainnet Sky 🌐

Rabbit hops through networks bright and clear,
Noders' services bringing connections near,
RPC, API, gRPC in harmony sing,
Celestia's web of nodes taking wing! 🐰🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a1917e and dc6d1a7.

📒 Files selected for processing (1)
  • how-to-guides/mainnet.md (3 hunks)
🔇 Additional comments (4)
how-to-guides/mainnet.md (4)

152-152: LGTM: RPC endpoint addition follows conventions

The new RPC endpoint follows the established naming pattern and is correctly placed in the community endpoints section.


174-174: LGTM: API endpoint addition follows conventions

The new API endpoint follows the established naming pattern and is correctly placed in the community endpoints section.


Line range hint 152-194: Documentation structure maintained

The new endpoints are properly categorized and maintain the document's structure. The existing warning about not using community endpoints in production environments appropriately covers these new additions.


194-194: Verify the non-standard gRPC port number

While the endpoint follows the naming convention, the port number (11090) differs from the commonly used ports in other entries (443, 9090, or 9095). Please verify that this is the correct port number for the service.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jcstein jcstein merged commit 166b858 into celestiaorg:main Dec 19, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants