-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update to v0.18.1-arabica & v2.2.0-arabica #1734
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces updates to the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -3,7 +3,7 @@ const arabicaVersions = Object.freeze({ | |||
"app-latest-sha": "48173df3dc78f9348eedb3796f29ef9e9e5dc584", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that app is on v2.1.2 here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.vitepress/constants/arabica_versions.js (1)
6-7
: LGTM! Consider adding a comment for clarity.The updates to
node-latest-tag
andnode-latest-sha
are consistent with the PR objective of updating to v0.18.1-arabica. The changes are correctly implemented within thearabicaVersions
object.For improved clarity and easier future updates, consider adding a comment above these lines indicating the current version and the date of the last update. For example:
// Current version: v0.18.1-arabica (Last updated: YYYY-MM-DD) "node-latest-tag": "v0.18.1-arabica", "node-latest-sha": "ac0515f82c2ae3783cfc62670dab3ad93cada8a6",This addition would provide quick reference for maintainers and contributors about when these values were last changed.
thank you for reviews. can be merged once live |
Overview
Summary by CodeRabbit
v2.2.0-arabica
, enhancing functionality and performance.v0.18.1-arabica
, improving compatibility and stability.