-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update systemd.md #1691
Update systemd.md #1691
Conversation
fullnode NOLIMITFILE to 65535
WalkthroughThe change involves modifying the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -88,7 +88,7 @@ User=$USER | |||
ExecStart=$(which celestia) full start | |||
Restart=on-failure | |||
RestartSec=3 | |||
LimitNOFILE=1400000 | |||
LimitNOFILE=65535 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider potential impacts of reducing LimitNOFILE
.
The change from 1400000
to 65535
in the LimitNOFILE
setting significantly reduces the number of file descriptors that the node can handle simultaneously. This could affect the node's performance, especially under high load conditions. It's crucial to ensure that this new limit meets the operational requirements of the Celestia full storage node.
Consider conducting performance tests or gathering operational feedback to verify that the new file descriptor limit does not adversely affect the node's functionality.
closing as this is a duplicate PR #1639 |
fullnode NOLIMITFILE to 65535
Overview
Summary by CodeRabbit
Bug Fixes
LimitNOFILE
setting in the systemd service configuration to a standard value, improving compatibility with Linux distributions.Impact Note