-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update arbitrum-integration.md - fix file name and add back credit to @ferret-san, remove mocha guide from menu temporarily #1388
Conversation
WalkthroughThis update reflects the integration of Arbitrum into our development environment, streamlining deployment processes and enhancing compatibility with various networks. It marks a strategic move towards optimizing performance and cost-effectiveness in blockchain operations. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- developers/arbitrum-integration.md (1 hunks)
Additional comments: 1
developers/arbitrum-integration.md (1)
- 60-60: The addition of credit to @Ferret-san is appropriately placed within the context of the Blobstream integration section. This acknowledgment is crucial for maintaining the integrity of the documentation and recognizing contributions accurately. However, ensure that the link provided is accessible and points to the correct location in the repository to verify @Ferret-san's contribution.
@@ -57,7 +57,7 @@ Arbitrum `SequencerInbox.sol` contract. | |||
In the `SequencerInbox.sol` contract, the `validateBatchData` | |||
modifier has been designed to authenticate that the data root is | |||
on Celestia when reading a batch of data. This is achieved by the | |||
[following code in `arbnode/sequencer_inbox.go`](https://github.com/celestiaorg/nitro-contracts/blob/celestia/blobstream/src/bridge/SequencerInbox.sol#L334-L360): | |||
[following code in `SequencerInbox.sol` by @Ferret-San](https://github.com/celestiaorg/nitro-contracts/blob/celestia/blobstream/src/bridge/SequencerInbox.sol#L334-L360): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also fixes incorrect file name
Validation has been achieved locally, see full logs and an example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
public/img/nitro-vroom-devnet.png
is excluded by:!**/*.png
public/img/nitro-vroom.png
is excluded by:!**/*.png
Files selected for processing (3)
- .vitepress/config.ts (1 hunks)
- developers/arbitrum-deploy.md (2 hunks)
- developers/arbitrum-mocha.md (1 hunks)
Files skipped from review due to trivial changes (1)
- developers/arbitrum-mocha.md
Additional comments: 1
developers/arbitrum-deploy.md (1)
- 118-120: The update to the tip about RAM and CPU requirements for validating blocks with WASM is clear and concise. However, ensure that the specific RAM and CPU requirements are based on accurate and up-to-date benchmarks to avoid misleading users.
Overview
Reverts accidental change from #1387
Checklist
Summary by CodeRabbit
.vitepress/config.ts
file.developers/arbitrum-deploy.md
file.developers/arbitrum-mocha.md
file.