Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollups overview page #1085

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Rollups overview page #1085

merged 9 commits into from
Oct 3, 2023

Conversation

Mackenzie-OO7
Copy link
Contributor

@Mackenzie-OO7 Mackenzie-OO7 commented Sep 26, 2023 •
edited by jcstein
Loading

Overview

Resolves #686

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Mackenzie-OO7 Mackenzie-OO7 marked this pull request as ready for review September 26, 2023 02:20
@jcstein jcstein self-requested a review September 26, 2023 20:52
jcstein
jcstein requested changes Sep 29, 2023
View reviewed changes
docs/nodes/celestia-app-commands.md Outdated Show resolved Hide resolved
docs/nodes/celestia-app-commands.md Outdated Show resolved Hide resolved
sidebars.js Show resolved Hide resolved
docs/developers/rollup-overview.md Outdated Show resolved Hide resolved
docs/developers/rollup-overview.md Outdated Show resolved Hide resolved
@Mackenzie-OO7
Copy link
Contributor Author

I've made the requested changes now.

@jcstein jcstein force-pushed the rollups-overview-page branch from df73767 to 392b806 Compare October 3, 2023 17:15
@jcstein jcstein self-requested a review October 3, 2023 17:16
jcstein
jcstein approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jcstein jcstein added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 3, 2023
@jcstein jcstein merged commit 7e25368 into celestiaorg:main Oct 3, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 3, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Celestia Contributor:

GitPOAP: 2023 Celestia Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@jcstein
Copy link
Member

jcstein commented Oct 3, 2023 •
edited
Loading

cc @Mackenzie-OO7 for the GitPOAP! thank you for your contribution to the documentation.

@Mackenzie-OO7
Copy link
Contributor Author

cc @Mackenzie-OO7 for the GitPOAP! thank you for your contribution to the documentation.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcstein jcstein jcstein approved these changes

Assignees

@Mackenzie-OO7 Mackenzie-OO7

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Rollups overview page
2 participants
@Mackenzie-OO7 @jcstein