fix: clarifying blob.GetAll godoc #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
docs:godocs
distractedm1nd
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
ramin
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3090 +/- ##
==========================================
+ Coverage 50.91% 51.37% +0.46%
==========================================
Files 177 177
Lines 11139 11139
==========================================
+ Hits 5671 5723 +52
+ Misses 4969 4921 -48
+ Partials 499 495 -4 ☔ View full report in Codecov by Sentry. |
ramin
approved these changes
Jan 10, 2024
walldiss
approved these changes
Jan 12, 2024
vgonkivs
approved these changes
Jan 15, 2024
renaynay
pushed a commit
that referenced
this pull request
Jan 23, 2024
The previous godoc led to some confusion because it got understood as getting all blobs *under* the given height. Co-authored-by: Viacheslav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous godoc led to some confusion because it got understood as getting all blobs under the given height.