chore(cmd): add a newline after printing token so it doesn't run into shell prompt #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramin
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Wondertan
approved these changes
Oct 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #2887 +/- ##
==========================================
+ Coverage 50.38% 51.84% +1.46%
==========================================
Files 167 167
Lines 10801 10801
==========================================
+ Hits 5442 5600 +158
+ Misses 4874 4712 -162
- Partials 485 489 +4
|
renaynay
approved these changes
Nov 1, 2023
renaynay
changed the title
walldiss
approved these changes
Nov 1, 2023
vgonkivs
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor annoyance where running
auth adminalways has the token output run right into the next shell prompt.