Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(share/ipld): obliterate expensive ipld getter tracing #2832

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Oct 10, 2023

The load these traces can produce is massive. In the case of ODS size 128 and the whole block is sampled for namespace data, it will be 48896 spans (128*2-1)*128*2 - (128 * 128). Besides, there is zero value this tracing brought us so far.

@codecov-commenter
Copy link

Codecov Report

Merging #2832 (a755aa7) into main (00b32a8) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2832      +/-   ##
==========================================
- Coverage   51.50%   51.16%   -0.35%     
==========================================
  Files         168      168              
  Lines       10764    10727      -37     
==========================================
- Hits         5544     5488      -56     
- Misses       4743     4758      +15     
- Partials      477      481       +4     
Files Coverage Δ
share/ipld/get.go 65.71% <ø> (-2.09%) ⬇️
share/ipld/get_shares.go 89.65% <ø> (-1.78%) ⬇️
share/ipld/namespace_data.go 78.57% <ø> (-5.64%) ⬇️
share/ipld/nmt.go 50.70% <ø> (ø)

... and 5 files with indirect coverage changes

@Wondertan Wondertan merged commit 3e56a04 into main Oct 10, 2023
@Wondertan Wondertan deleted the hlib/ipld/remove-get-metrics branch October 10, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples kind:chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants